Replace PersonType with PersonKind #96
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. unstable versions of Jellyfin aren’t supported so I am going to mark this PR as blocked until 10.9 is released |
crobibero
added
release-prep
Omg you are completely right! I forgot I am running unstable and hence the plugin wasn't working for me! I guess I'll give it an install with this and update the PR if anything else breaks with it on the latest unstable |
|
This has been fixed in the greater 10.9 PR. Thank you for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I seem to be getting some errors on my end of the pluging saying these fields are strings, but I noticed in march these were changed to
PersonKinds instead.https://github.com/jellyfin/jellyfin/blob/master/Jellyfin.Data/Enums/PersonKind.cs
The commit looks like it was from 6 months ago, so I figured to try and fix the plugin.
Not sure how to test if this works (other than making the plugin and installing it myself)