Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Marker Deletion Robustness #2

Open
hendursaga opened this issue Jan 6, 2023 · 3 comments
Open

Comment Marker Deletion Robustness #2

hendursaga opened this issue Jan 6, 2023 · 3 comments

Comments

@hendursaga
Copy link

On the project page, it notes:

Warning: If you manually delete a comment marker in the score and then activate the stale comment, MuseScore will crash trying to select a no longer existing Staff Text. Always use the Delete button from the plugin itself!

Has this been fixed? Is this a limitation of MuseScore? Or could you add checks so that it wouldn't crash, or something?

@jeetee
Copy link
Owner

jeetee commented Jan 6, 2023

I'd consider it a bug in the plugin interface of MuseScore that attempting to select non-existing elements crashes it rather than skipping that element in the selection code.

The cause is that the element pointer the plugin has became a dangling raw pointer to a no longer existing score element.

@hendursaga
Copy link
Author

I'd consider it a bug in the plugin interface of MuseScore

I suppose so, too.

Is there a bug filed on this already, for MuseScore?

@jeetee
Copy link
Owner

jeetee commented Jan 6, 2023

Filing one against MS3 is no use, as that branch is no longer in development (nor has it been for over a year).
And given that the plugin API for MS4 is still in flux, it can't hurt to enter one against it; assuming this issue is still the case in there and that the plugin is able to run at all.
Which it currently can't as dockable plugins are not supported in it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants