You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In many places the indefinite article 'a' is manipulated, either by stripping it away or treating it as 1. The article 'an' should be processed in the same way.
In all these regexes a should be replaced with an? to cover both articles.
Can you give a few examples of the test cases you would make pass with this change? I can't think of the cases where you would have an instead of a and want it treated the same way. I also haven't spent much time with this codebase in awhile now so may just be missing the context for this.
Problem
In many places the indefinite article 'a' is manipulated, either by stripping it away or treating it as 1. The article 'an' should be processed in the same way.
In all these regexes
a
should be replaced withan?
to cover both articles.Occurrences
numerizer/lib/providers/english_provider.rb
Line 110 in 31c1b1f
numerizer/lib/providers/english_provider.rb
Line 124 in 31c1b1f
numerizer/lib/providers/english_provider.rb
Line 126 in 31c1b1f
Resolution
I could make a PR if there's consensus that this needs to be fixed.
The text was updated successfully, but these errors were encountered: