Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive bitwise operation on MaskGroup #115

Open
jacanchaplais opened this issue Mar 13, 2023 · 0 comments
Open

Recursive bitwise operation on MaskGroup #115

jacanchaplais opened this issue Mar 13, 2023 · 0 comments
Assignees
Labels
design enhancement New feature or request

Comments

@jacanchaplais
Copy link
Owner

jacanchaplais commented Mar 13, 2023

Description

Currently performing a bitwise operation with MaskGroup instances returns a MaskArray, losing all nesting information. Would be good to have a recursive update over the MaskGroup.

Potential problem

The order of precedence for a bitwise operation between two MaskGroup instances would then become ambiguous. Which nesting structure should be preserved?

Potential solution

Could form a new MaskGroup, which contains both of the inputs, with agg_op defined to the relevant bitwise operation. This would preserve the structure, and deliver the desired behaviour, but would increase levels of nesting, and if users wanted to select out individual MaskArray objects, they would not have the masking applied.

Ideas need to be fleshed out more. Will place this on the backlog for future development.

@jacanchaplais jacanchaplais added enhancement New feature or request design labels Mar 13, 2023
@jacanchaplais jacanchaplais self-assigned this Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant