Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide update method of sql files (or move those from chart itself) #2

Open
JuniorJPDJ opened this issue May 30, 2024 · 3 comments
Open

Comments

@JuniorJPDJ
Copy link
Collaborator

JuniorJPDJ commented May 30, 2024

I'm not sure if holding sql files inside the chart is a good idea as it will become out of date quickly.
If you can propose (or even better - implement) some solution to make it not become out of date

Originally posted by @JuniorJPDJ in #1 (comment)

CC: @perennialtech

@perennialtech
Copy link
Contributor

I'm not sure if holding sql files inside the chart is a good idea as it will become out of date quickly.

This issue never really crossed my mind.

I've been had the SQL files as a ConfigMap in a local Helm chart for several months without encountering any issues. It's also worth noting that the last change to the Invidious SQL schema was made over two years ago (see iv-org/invidious@cdc007c).

On the other hand, I'm not too sure how to handle migrations for the database if they ever become necessary in the future. Perhaps a solution could be implementing a custom migration script that is triggered by a Helm hook?

@JuniorJPDJ
Copy link
Collaborator Author

I'm not sure invidious is implementing any migrations, those sql files are used only for db init.

@SamantazFox
Copy link
Member

Invidious does indeed have a built-in migration system, which to this date has not been used because a proper init and upgrade process for docker needs to be documented.

We have a bunch of PRs making DB changes that are waiting to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants