Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support old-fashioned patches #446

Open
paradox460 opened this issue Jul 8, 2024 · 2 comments
Open

Support old-fashioned patches #446

paradox460 opened this issue Jul 8, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@paradox460
Copy link

The PatchSet and PatchDefinition systems have many advantages to traditional patches, but one shortcoming is they can't work with plain text files. Some mods use plain text to store things like MOTDs, and it would be nice to patch in a reliable way. I've been using interpolation where appropriate, but it's not ideal.

Having the ability to use .patch files, as used by the unix patch command, would be extremely useful. While these are more fragile than the path-based system, they also have the ability to do far more variety of changes

@paradox460
Copy link
Author

This would make the changes I'm attempting in #445 absolutely trivial, for example

@itzg
Copy link
Owner

itzg commented Jul 8, 2024

Yeah, the current patching is just a best effort implementation using the library that was already in use for JSON processing. Generic patch file support makes sense to include as an option.

I'd be happy for a sensible PR for this since I probably won't be able to get to this for quite some time.

@itzg itzg added the enhancement New feature or request label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

2 participants