From b64044f104edd1c38134c6b963abff3d79941f94 Mon Sep 17 00:00:00 2001 From: BradyJ27 Date: Thu, 27 Jul 2023 20:33:45 -0600 Subject: [PATCH] runner: Convert idle-timeout="never" to 0 with GitLab driver (#1408) * runner: Convert idle-timeout="never" to 0 with GitLab driver GitLab runners do not support "never" as an argument for --wait-timeout, instead this should be 0, which by default is no timeout. Fixes #1407 * Fix linting error * Update src/drivers/gitlab.js --------- Co-authored-by: Daniel Barnes --- src/drivers/gitlab.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/drivers/gitlab.js b/src/drivers/gitlab.js index 932964ea6..489f64d35 100644 --- a/src/drivers/gitlab.js +++ b/src/drivers/gitlab.js @@ -200,6 +200,11 @@ class Gitlab { const { protocol, host } = new URL(this.repo); const { token } = await this.registerRunner({ tags: labels, name }); + let waitTimeout = idleTimeout; + if (idleTimeout === 'never') { + waitTimeout = '0'; + } + let dockerVolumesTpl = ''; dockerVolumes.forEach((vol) => { dockerVolumesTpl += `--docker-volumes ${vol} `; @@ -210,7 +215,7 @@ class Gitlab { --url "${protocol}//${host}" \ --name "${name}" \ --token "${token}" \ - --wait-timeout ${idleTimeout} \ + --wait-timeout ${waitTimeout} \ --executor "${IN_DOCKER ? 'shell' : 'docker'}" \ --docker-image "iterativeai/cml:${gpu ? 'latest-gpu' : 'latest'}" \ ${gpu ? '--docker-runtime nvidia' : ''} \