Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design React Kit - Next version based on Bootstrap Italia 2 #885

Closed
wants to merge 96 commits into from

Conversation

astagi
Copy link
Member

@astagi astagi commented Nov 8, 2022

This branch contains the work in progress (draft) for the update of the React kit to the latest Bootstrap Italia 2.0 framework - based on Bootstrap 5. This is an urgent question also because the planned EOL (End of Life) for Bootstrap 4 (January 1, 2023).

Things to do

  • Create branch next from master (will become main in the next major release).
  • Force the update (on the next branch) of all the dependencies, including Bootstrap Italia 2 and the latest React Strap, both based on Bootstrap 5.
  • Add a label next to issues.
  • Verify, and update CI and GitHub Actions.
  • Start opening, if needed, dedicated issues for next branch. For each components we will have to:
    • Verify and update, markup and classes of the resulting DOM template, compared to Bootstrap Italia 2
    • Check the rendering of the component (CSS application including spacing, dimensions, typography, ...), compared to Bootstrap Italia and the new UI kit
    • Check the behavior of the component (JavaScript, user interaction, states, keyboard interaction for accessibility, ...), compared to Bootstrap Italia 2
    • Verify the accessibility of the component, including automatic tests and manual evaluations by a11y experts, if possible
    • Evaluate the need to supplement the component storybook documentation with more detailed information.

Feedbacks and contributions are more than welcome! 🎉

…o next

# Conflicts:
#	src/Icon/assets/ItArrowDown.tsx
#	src/Icon/assets/ItArrowDownCircle.tsx
#	src/Icon/assets/ItArrowDownTriangle.tsx
#	src/Icon/assets/ItArrowLeft.tsx
#	src/Icon/assets/ItArrowLeftCircle.tsx
#	src/Icon/assets/ItArrowLeftTriangle.tsx
#	src/Icon/assets/ItArrowRight.tsx
#	src/Icon/assets/ItArrowRightCircle.tsx
#	src/Icon/assets/ItArrowRightTriangle.tsx
#	src/Icon/assets/ItArrowUp.tsx
#	src/Icon/assets/ItArrowUpCircle.tsx
#	src/Icon/assets/ItArrowUpTriangle.tsx
#	src/Icon/assets/ItBehance.tsx
#	src/Icon/assets/ItBookmark.tsx
#	src/Icon/assets/ItBox.tsx
#	src/Icon/assets/ItBurger.tsx
#	src/Icon/assets/ItCalendar.tsx
#	src/Icon/assets/ItCamera.tsx
#	src/Icon/assets/ItCard.tsx
#	src/Icon/assets/ItChartLine.tsx
#	src/Icon/assets/ItCheck.tsx
#	src/Icon/assets/ItCheckCircle.tsx
#	src/Icon/assets/ItClip.tsx
#	src/Icon/assets/ItClock.tsx
#	src/Icon/assets/ItClose.tsx
#	src/Icon/assets/ItCloseBig.tsx
#	src/Icon/assets/ItCloseCircle.tsx
#	src/Icon/assets/ItCodeCircle.tsx
#	src/Icon/assets/ItComment.tsx
#	src/Icon/assets/ItCopy.tsx
#	src/Icon/assets/ItDelete.tsx
#	src/Icon/assets/ItDesignersItalia.tsx
#	src/Icon/assets/ItDownload.tsx
#	src/Icon/assets/ItError.tsx
#	src/Icon/assets/ItExchangeCircle.tsx
#	src/Icon/assets/ItExternalLink.tsx
#	src/Icon/assets/ItFacebook.tsx
#	src/Icon/assets/ItFacebookSquare.tsx
#	src/Icon/assets/ItFile.tsx
#	src/Icon/assets/ItFiles.tsx
#	src/Icon/assets/ItFlag.tsx
#	src/Icon/assets/ItFlickr.tsx
#	src/Icon/assets/ItFlickrSquare.tsx
#	src/Icon/assets/ItFolder.tsx
#	src/Icon/assets/ItFullscreen.tsx
#	src/Icon/assets/ItFunnel.tsx
#	src/Icon/assets/ItGithub.tsx
#	src/Icon/assets/ItHearing.tsx
#	src/Icon/assets/ItHelp.tsx
#	src/Icon/assets/ItHelpCircle.tsx
#	src/Icon/assets/ItHorn.tsx
#	src/Icon/assets/ItInbox.tsx
#	src/Icon/assets/ItInfoCircle.tsx
#	src/Icon/assets/ItInstagram.tsx
#	src/Icon/assets/ItKey.tsx
#	src/Icon/assets/ItLessCircle.tsx
#	src/Icon/assets/ItLink.tsx
#	src/Icon/assets/ItLinkedin.tsx
#	src/Icon/assets/ItLinkedinSquare.tsx
#	src/Icon/assets/ItList.tsx
#	src/Icon/assets/ItLock.tsx
#	src/Icon/assets/ItLocked.tsx
#	src/Icon/assets/ItMail.tsx
#	src/Icon/assets/ItMapMarker.tsx
#	src/Icon/assets/ItMapMarkerCircle.tsx
#	src/Icon/assets/ItMapMarkerPlus.tsx
#	src/Icon/assets/ItMaximize.tsx
#	src/Icon/assets/ItMaximizeAlt.tsx
#	src/Icon/assets/ItMedium.tsx
#	src/Icon/assets/ItMediumSquare.tsx
#	src/Icon/assets/ItMinimize.tsx
#	src/Icon/assets/ItMinus.tsx
#	src/Icon/assets/ItMinusCircle.tsx
#	src/Icon/assets/ItMoreActions.tsx
#	src/Icon/assets/ItMoreItems.tsx
#	src/Icon/assets/ItNote.tsx
#	src/Icon/assets/ItOpenSource.tsx
#	src/Icon/assets/ItPa.tsx
#	src/Icon/assets/ItPasswordInvisible.tsx
#	src/Icon/assets/ItPasswordVisible.tsx
#	src/Icon/assets/ItPencil.tsx
#	src/Icon/assets/ItPiattaforme.tsx
#	src/Icon/assets/ItPin.tsx
#	src/Icon/assets/ItPlug.tsx
#	src/Icon/assets/ItPlus.tsx
#	src/Icon/assets/ItPlusCircle.tsx
#	src/Icon/assets/ItPresentation.tsx
#	src/Icon/assets/ItPrint.tsx
#	src/Icon/assets/ItRss.tsx
#	src/Icon/assets/ItRssSquare.tsx
#	src/Icon/assets/ItSearch.tsx
#	src/Icon/assets/ItSettings.tsx
#	src/Icon/assets/ItShare.tsx
#	src/Icon/assets/ItSoftware.tsx
#	src/Icon/assets/ItStarFull.tsx
#	src/Icon/assets/ItStarOutline.tsx
#	src/Icon/assets/ItTeamDigitale.tsx
#	src/Icon/assets/ItTelephone.tsx
#	src/Icon/assets/ItTool.tsx
#	src/Icon/assets/ItTwitter.tsx
#	src/Icon/assets/ItTwitterSquare.tsx
#	src/Icon/assets/ItUnlocked.tsx
#	src/Icon/assets/ItUpload.tsx
#	src/Icon/assets/ItUser.tsx
#	src/Icon/assets/ItVideo.tsx
#	src/Icon/assets/ItWarning.tsx
#	src/Icon/assets/ItWarningCircle.tsx
#	src/Icon/assets/ItWhatsapp.tsx
#	src/Icon/assets/ItWhatsappSquare.tsx
#	src/Icon/assets/ItWifi.tsx
#	src/Icon/assets/ItYoutube.tsx
#	src/Icon/assets/ItZoomIn.tsx
#	src/Icon/assets/ItZoomOut.tsx
#	src/ThumbNav/ThumbNavItem.tsx
#	stories/Form/Autocomplete/AutocompleteExample.tsx
@astagi astagi added the next label Nov 8, 2022
@vercel
Copy link

vercel bot commented Nov 8, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-react-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2023 0:34am

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Attention: 39 lines in your changes are missing coverage. Please review.

Comparison is base (23bed3f) 98.07% compared to head (d59741c) 95.42%.

Files Patch % Lines
src/BackToTop/BackToTop.tsx 22.22% 21 Missing ⚠️
src/GoBack/GoBack.tsx 50.00% 6 Missing ⚠️
src/Accordion/AccordionItem.tsx 50.00% 3 Missing ⚠️
src/Input/Input.tsx 80.00% 3 Missing ⚠️
src/Select/Select.tsx 66.66% 2 Missing and 1 partial ⚠️
src/Accordion/AccordionBody.tsx 0.00% 2 Missing ⚠️
src/Callout/CalloutMoreFooter.tsx 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #885      +/-   ##
==========================================
- Coverage   98.07%   95.42%   -2.66%     
==========================================
  Files         237      283      +46     
  Lines        3691     2775     -916     
  Branches      950      696     -254     
==========================================
- Hits         3620     2648     -972     
- Misses         71      125      +54     
- Partials        0        2       +2     
Flag Coverage Δ
unittests 95.42% <94.94%> (-2.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants