Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accordion types error #1036

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix: accordion types error #1036

merged 1 commit into from
Mar 21, 2024

Conversation

Virtute90
Copy link
Contributor

Fixes #1034

PR Checklist

  • My branch is up-to-date with the Upstream main branch.
  • The unit tests pass locally with my changes (if applicable).
  • I have added tests that prove my fix is effective or that my feature works (if applicable).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves:

I extended the accordion element interfaces with react's HTML interface

Copy link

vercel bot commented Mar 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-react-kit ✅ Ready (Inspect) Visit Preview Mar 21, 2024 11:21am

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.47%. Comparing base (2acd92f) to head (fb3935e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1036   +/-   ##
=======================================
  Coverage   94.47%   94.47%           
=======================================
  Files         291      291           
  Lines        3003     3003           
  Branches      766      766           
=======================================
  Hits         2837     2837           
  Misses        155      155           
  Partials       11       11           
Flag Coverage Δ
unittests 94.47% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astagi astagi merged commit 4e854e7 into italia:main Mar 21, 2024
6 checks passed
@Virtute90 Virtute90 deleted the fix/accordion-interface branch March 21, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Typescript compilation error on Accordion component
2 participants