Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade bsi to latest version #1007

Merged
merged 27 commits into from
Feb 7, 2024
Merged

feat: upgrade bsi to latest version #1007

merged 27 commits into from
Feb 7, 2024

Conversation

astagi
Copy link
Member

@astagi astagi commented Jan 10, 2024

Fixes #1000

PR Checklist

  • My branch is up-to-date with the Upstream main branch.
  • The unit tests pass locally with my changes (if applicable).
  • I have added tests that prove my fix is effective or that my feature works (if applicable).
  • I have added necessary documentation (if appropriate).

Short description of what this resolves:

Changes proposed in this Pull Request:

Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
design-react-kit ✅ Ready (Inspect) Visit Preview Feb 7, 2024 1:54pm

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (ce8d103) 94.77% compared to head (55055f3) 92.17%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/Header/HeaderToggler.tsx 25.00% 3 Missing ⚠️
src/Input/Input.tsx 0.00% 2 Missing ⚠️
src/LinkList/LinkListItem.tsx 84.61% 2 Missing ⚠️
src/Megamenu/MegamenuFooter.tsx 71.42% 2 Missing ⚠️
src/Megamenu/MegamenuItem.tsx 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1007      +/-   ##
==========================================
- Coverage   94.77%   92.17%   -2.60%     
==========================================
  Files         283      282       -1     
  Lines        2813     2825      +12     
  Branches      715      720       +5     
==========================================
- Hits         2666     2604      -62     
- Misses        145      217      +72     
- Partials        2        4       +2     
Flag Coverage Δ
unittests 92.17% <67.64%> (-2.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@astagi astagi linked an issue Jan 15, 2024 that may be closed by this pull request
3 tasks
@astagi astagi merged commit 27016b7 into main Feb 7, 2024
5 of 6 checks passed
@astagi astagi deleted the feat/upgrade-bsi-2.8 branch March 15, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants