From a0b0d98aafe2c55b81197c90ddfe5a7fd814307e Mon Sep 17 00:00:00 2001 From: isuru Date: Tue, 2 Apr 2024 07:58:27 +0530 Subject: [PATCH] fix cron failure of unable to print #179 --- lib.php | 8 ++++---- locallib.php | 7 ++++--- version.php | 4 ++-- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/lib.php b/lib.php index a4c0693..284e05e 100644 --- a/lib.php +++ b/lib.php @@ -48,7 +48,7 @@ * ======== CONSTANTS ========================================== */ -define('REMINDERS_DAYIN_SECONDS', 24 * 3600); +define('REMINDERS_DAYIN_SECONDS', 24 * 3600 * 7); define('REMINDERS_FIRST_CRON_CYCLE_CUTOFF_DAYS', 1); @@ -401,11 +401,11 @@ function local_reminders_cron_pre($currtime, $timewindowstart) { $mailresult = message_send($eventdata); if (!$mailresult) { - mtrace("Could not send out message for event#$event->id to user $eventdata->userto"); + mtrace("Could not send out reminder for event#$event->id to user $touser->id"); } else { - mtrace('[LOCAL_REMINDERS] Mail Result: '.$mailresult); + mtrace('[LOCAL_REMINDERS] Mail successfully sent to user: '.$touser->id); } - } catch (\Exception $mex) { + } catch (\Throwable $mex) { $failedcount++; mtrace('Error: local/reminders/lib.php local_reminders_cron(): '.$mex->getMessage()); } diff --git a/locallib.php b/locallib.php index d86320b..326db9e 100644 --- a/locallib.php +++ b/locallib.php @@ -252,12 +252,13 @@ function send_overdue_activity_reminders($curtime, $timewindowstart, $activityro $eventdata = $reminderref->get_updating_send_event(REMINDERS_CALL_TYPE_OVERDUE, $fromuser, $touser, $ctxinfo); $mailresult = message_send($eventdata); - mtrace('[LOCAL_REMINDERS] Post Activity Mail Result: '.$mailresult); if (!$mailresult) { - mtrace("[LOCAL REMINDERS] Could not send out message for event#$event->id to user $eventdata->userto"); + mtrace("[LOCAL REMINDERS] Could not send out reminder for event#$event->id to user $touser->id"); + } else { + mtrace('[LOCAL_REMINDERS] Post Activity Mail sent to user: '.$touser->id); } - } catch (\Exception $mex) { + } catch (\Throwable $mex) { mtrace('[LOCAL REMINDERS] Error: local/reminders/locallib.php send_post_activity_reminders(): '.$mex->getMessage()); } } diff --git a/version.php b/version.php index 0740fde..7e1c463 100644 --- a/version.php +++ b/version.php @@ -25,8 +25,8 @@ defined('MOODLE_INTERNAL') || die(); -$plugin->version = 2024011200; +$plugin->version = 2024040200; $plugin->requires = 2018051700; // Require moodle 3.5 or higher. -$plugin->release = '2.7.1'; +$plugin->release = '2.7.2'; $plugin->maturity = MATURITY_STABLE; $plugin->component = 'local_reminders';