Update firmware readme.md #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remove the white space and * --> _ changes. Also shouldn't it be step 4 rather than step 7? |
|
I will and yea it should be step 4 , i will most definitely do that .
…On Thu, 4 Jul 2024 at 7:08 AM, thias15 ***@***.***> wrote:
Please remove the white space and * --> _ changes. Also shouldn't it be
step 4 rather than step 7?
—
Reply to this email directly, view it on GitHub
<#433 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BCXDYQVTLVNLPFA6HFLNY33ZKSRSLAVCNFSM6AAAAABJNZLH5SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBXHA2DAMJUGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I changed the sequence of instruction by moving it from instruction 7 to instruction 4 and the white space has been removed.
|
@thias15 , please review the updated change , i changed the instruction from instruction 7 to 4 |
thias15
changed the title
thias15
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added step 7 to the readme file in the firmware directory , earlier some users might face some error as the default upload speed is set to 921600 , but certain esp32 chips would throw error while uploading the sketch , Added the basic instruction to simple change the upload speed