Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using one phone as Wifi AP and the other connect to this AP, controller app and robot app can NOT connect #387

Closed
yijunwu opened this issue Dec 9, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@yijunwu
Copy link
Contributor

yijunwu commented Dec 9, 2023

Describe the bug
When using one phone as Wifi AP and the other connect to this AP, controller app and robot app can NOT connect

To Reproduce
Steps to reproduce the behavior:

  1. Two phones, lets say A and B. Start Wifi Access Point on A
  2. On phone B, connect to that Wifi provided by A
  3. Run robot App on A, select phone as control mode; Run controller App on B
  4. Robot app can not find controller app (service) hence from user point of view, controller can't connect to robot

Expected behavior
When using one phone as Wifi AP and the other connect to this AP, controller app and robot app can connect. This will be a convinient way to allow users to use phone control mode even in out-door scenario.

Smartphone (please complete the following information):

  • Device: Samsung S20FE, Samsung A40S, Samsung A6S tested
  • OS: Android 10, 11
  • Version 0.7.1, master

Additional context
I've worked out a fix for this issue, will create PR soon.

@yijunwu
Copy link
Contributor Author

yijunwu commented Dec 9, 2023

I've create a PR (#388) to fix this. Please kindly review and merge.

@hardikgarg02
Copy link
Contributor

Its working fine for android. Can you also check same functionality for IOS application.

@yijunwu
Copy link
Contributor Author

yijunwu commented Dec 17, 2023

Its working fine for android. Can you also check same functionality for IOS application.

I'll take a look, but I'm not familiar with iOS dev, so I'm not sure how much time it'll take.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

3 participants