Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav bar II #18

Merged
merged 6 commits into from
Sep 22, 2024
Merged

Nav bar II #18

merged 6 commits into from
Sep 22, 2024

Conversation

D33102
Copy link
Contributor

@D33102 D33102 commented Sep 15, 2024

fix: responsiveness and refactoring file

@D33102 D33102 self-assigned this Sep 15, 2024
src/lib/components/Navbar.svelte Outdated Show resolved Hide resolved
src/lib/components/Navbar.svelte Show resolved Hide resolved
@macgeargear
Copy link
Contributor

macgeargear commented Sep 18, 2024

Screenshot 2024-09-18 at 2 42 34 pm

@D33102 please make sure that when the nav bar on the mobile is open the background must be blurred and slightly darkened an

but I'm not sure if it is necessary @punchanabu

@punchanabu
Copy link
Member

Screenshot 2024-09-18 at 2 42 34 pm @D33102 please make sure that when the nav bar on the mobile is open the background must be blurred and slightly darkened an

but I'm not sure if it is necessary @punchanabu

Yeah I think this also should be implemented too

@D33102
Copy link
Contributor Author

D33102 commented Sep 21, 2024

Screenshot 2024-09-18 at 2 42 34 pm @D33102 please make sure that when the nav bar on the mobile is open the background must be blurred and slightly darkened an but I'm not sure if it is necessary @punchanabu

Yeah I think this also should be implemented too

I will do this soonn.

Copy link
Member

@punchanabu punchanabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ฝากแก้ที่ comment หน่อยแก้เสร็จ merge ได้เลย

src/lib/components/Navbar.svelte Outdated Show resolved Hide resolved
@punchanabu punchanabu merged commit 583c6c7 into dev Sep 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants