Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2/foxy Support #41

Open
RoboticsIntelligence opened this issue Jul 6, 2021 · 7 comments
Open

ROS2/foxy Support #41

RoboticsIntelligence opened this issue Jul 6, 2021 · 7 comments

Comments

@RoboticsIntelligence
Copy link

RoboticsIntelligence commented Jul 6, 2021

I'm wondering if anyone interested and/or working on porting ira_laser_tools to ROS2/foxy?

@kashifkhalid
Copy link

following

@JackFrost67
Copy link
Contributor

wip

@relffok
Copy link

relffok commented Aug 27, 2021

I started porting it a while ago but it turned out to become a little different from the original method. See forked repo.
Due to the lack of time it is still pretty rudimentary and missing quite a lot but the laserscan_multi_merger node is usable in my project.
Feel free to check it out/contribute/use for your migration!

@JackFrost67
Copy link
Contributor

I started porting it a while ago but it turned out to become a little different from the original method. See forked repo.
Due to the lack of time it is still pretty rudimentary and missing quite a lot but the laserscan_multi_merger node is usable in my project.
Feel free to check it out/contribute/use for your migration!

I’ve started to port everything too, but I’ve to read more about ROS2 stuff. I have literally no time atm, but for sure I will take a look at your implementation. Thank you for the support.

@tonaaskarwur
Copy link

tonaaskarwur commented Aug 31, 2021

I started porting it a while ago but it turned out to become a little different from the original method. See forked repo.
Due to the lack of time it is still pretty rudimentary and missing quite a lot but the laserscan_multi_merger node is usable in my project.
Feel free to check it out/contribute/use for your migration!

I did my attempt to port this too, but couldn't find a way to parse topics and handle dynamic param in ros2. My workaround was by trying to subscribe to both lidars directly. Check it here.
The basic idea is following ira_laser_tools, but also missing many things. Thanks for the effort on porting @relffok, I will check your repo and see what goes from there.

@nakai-omer
Copy link

We created a PR to support latest ros2:
#47

@ryanpennings
Copy link

We used @nakai-omer 's humble PR and also did a foxy branch which is working for us. https://github.com/MSDRobotics/ira_laser_tools/tree/foxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants