Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace view_func with default_view_func to make them overwriteable #2831

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

replace view_func with default_view_func to make them overwriteable #2831

wants to merge 1 commit into from

Conversation

karkraeg
Copy link
Member

@karkraeg karkraeg commented Sep 5, 2024

❤️ Thank you for your contribution!

Description

This change makes APP_RDM_USER_DASHBOARD_ROUTES configurable by using an approach like this in invenio.cfg:

from invenio_app_rdm.config import APP_RDM_ROUTES
from invenio_app_rdm.config import APP_RDM_USER_DASHBOARD_ROUTES
from mysite.views import custom_render
APP_RDM_ROUTES["index"] = ("/", custom_render)
APP_RDM_USER_DASHBOARD_ROUTES["uploads"] = ("/me/uploads", custom_render)

@karkraeg karkraeg mentioned this pull request Sep 5, 2024
Open
@karkraeg karkraeg linked an issue Sep 5, 2024 that may be closed by this pull request
APP_RDM_USER_DASHBOARD_ROUTES can't be reconfigured with tuples #2824
Open
@karkraeg
Copy link
Member Author

Hi @alejandromumo do you think that's a good solution, or do you see anything speaking against it from your perspective?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alejandromumo alejandromumo Awaiting requested review from alejandromumo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

APP_RDM_USER_DASHBOARD_ROUTES can't be reconfigured with tuples
1 participant
@karkraeg