Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal API Cleanup #26

Open
rofinn opened this issue Jul 10, 2019 · 1 comment
Open

Internal API Cleanup #26

rofinn opened this issue Jul 10, 2019 · 1 comment

Comments

@rofinn
Copy link
Member

rofinn commented Jul 10, 2019

#20 introduced a bunch of deprecations and public API changes to help improve maintainability. There is still some work that needs to be done to improve the internal API (e.g., #20 (comment), #20 (comment))
@rofinn rofinn mentioned this issue Jul 10, 2019
Merged
2 tasks
@rofinn
Copy link
Member Author

rofinn commented Aug 2, 2019 •
edited
Loading

Hmmm, I just realized that a another benefit of moving the condition from the above comment to a function that dispatches would be that you could define custom logic for what counts as missing for an iterable like an array or NamedTuple.

@oxinabox Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rofinn