[PB-1678]:Fix/Update wrong login credentials text #1300
+19
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CandelR
reviewed
Oct 3, 2024
| @@ -172,7 +172,11 @@ export default function LogIn(): JSX.Element { | |||
| navigationService.history.push(`/activate/${email}`); | |||
| } | |||
|
|
|||
| setLoginError([castedError.message]); | |||
| setLoginError([ | |||
| castedError.message.includes('Wrong login credentials') | |||
There was a problem hiding this comment.
Instead of comparing the error message to display that message, I think that will be bettter try doing it with the http status code. That way even if the backend change the message it will still work if the numerical code is the same.
Deploying drive-web with
|
| Latest commit: |
37ede4b
|
| Status: | ⚡️ Build in progress... |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update wrong login text and transaltions