Larry said there's a way to speed this up

[robbyblum]

ottd-util/random.nut

Line 6 in 97824ae

function RandomAccessGSList(gslist) {

I will never let you forget anything

[larryfenn]

we don't need to fill the array up more than the result of GSRandRange. should cut memory usage (and probably run time) in half in the average case.

[robbyblum]

Iterating over the GSList entries has a deterministic order, right?

[larryfenn]

Yes, provided there is no other operation going on to GSList. There may be a race condition if elsewhere in the program GSList is being resorted.

[robbyblum]

Mmm, good to know. I imagine that would matter more for scripts that run during gameplay than for the industry constructor.

[larryfenn]

It should be stated that the current implementation is also potentially faulty to a race condition

[larryfenn]

While I have not sped this up I realized this was itself a way better implementation of random access than what I had in the industry placer.