Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could netcdf4 be pulled out to isolate GPL code? #41

Open
danielballan opened this issue Jun 12, 2019 · 5 comments
Open

Could netcdf4 be pulled out to isolate GPL code? #41

danielballan opened this issue Jun 12, 2019 · 5 comments

Comments

@danielballan
Copy link
Member

I think netcdf4 is inflected with GPL code. I'm wondering if it could be made an optional dependency of intake-xarray, or moved into a separate intake-netcdf4 package.

Although conda-forge reports that netcdf4 has an MIT liencse, netcdf4 has a hard dependency on cftime which has a GPL license.

h/t @dylanmcreynolds who noticed this problem.

@danielballan
Copy link
Member Author

To be clear, I would be happy to do the work to make this happen if the maintainers of this package support the change.

@martindurant
Copy link
Member

It would be ok by me to have this only as an optional dependency, but, of course, the docs had better be clear (and good error message on import failure).

@jsignell
Copy link
Member

Yeah I am consistently surprised by the dependency on netcdf4. xarray doesn't depend on netcdf4, so we can probably look there for good error messaging.

@andersy005
Copy link
Member

It's my understanding that the license inccompatibility issue in netcdf4-ptyhon/cftime got fixed a few days ago: Unidata/netcdf4-python#1073.

@jsignell
Copy link
Member

Seems like the conscensus here is that it would be fine to remove the xarray dep, but I'm not sure whether there is any motivation for doing that if the license issue is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants