Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Cannot read property 'instance' of undefined #285

Open
feidaZhang opened this issue Mar 13, 2024 · 1 comment
Open

[Bug] Cannot read property 'instance' of undefined #285

feidaZhang opened this issue Mar 13, 2024 · 1 comment

Comments

@feidaZhang
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

I got the issue from sentry in production. I think it was caused by some render issues. Just add this to avoid the unknown issue.
image

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-popup-menu/src/MenuOption.js b/node_modules/react-native-popup-menu/src/MenuOption.js
index bc944ef..fc37090 100644
--- a/node_modules/react-native-popup-menu/src/MenuOption.js
+++ b/node_modules/react-native-popup-menu/src/MenuOption.js
@@ -20,6 +20,9 @@ export class MenuOption extends Component {
 
   _getMenusOnSelect() {
     const menu = this.props.ctx.menuActions._getOpenedMenu();
+    if(!menu) {
+        return () => true
+    }
     return menu.instance.props.onSelect;
   }
 

This issue body was partially generated by patch-package.

@amingsc
Copy link

amingsc commented Apr 5, 2024

i meet same error,fix with: ./gradlew clean...rebuild works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants