Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HoldingPen: exclude self from match candidates #3685

Open
ksachs opened this issue Oct 10, 2018 · 0 comments
Open

HoldingPen: exclude self from match candidates #3685

ksachs opened this issue Oct 10, 2018 · 0 comments

Comments

@ksachs
Copy link
Contributor

ksachs commented Oct 10, 2018

this is relevant only when re-starting a workflow

Expected Behavior

the stub-record created by a workflow should be excluded from the match candidates of itself.

Current Behavior

at some point in the workflow a stub-record is created to reserve the recid.
if the workflow is re-started after that step, this stub-record is a match candidate.
At least in cases when there is another real match candidate.

Steps to Reproduce (for bugs)

  • create a literature workflow that would halt for match approval
  • when it is waiting: re-start workflow

Context

a thesis was submitted twice, both waiting for selection.
After accepting one submission (https://labs.inspirehep.net/holdingpen/1257886)
I restarted the workflow of the other (https://labs.inspirehep.net/holdingpen/1257885) to get the match.
The stub-record of the submission seems to be in the match candidates.

Screenshots (if appropriate):

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant