fix: timeout http requests to Milkomeda backend #937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rhyslbw
requested review from
AngelCastilloB and
DominikGuzei
and removed request for
AngelCastilloB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Nami has an integration with Milkomeda, a Cardano EVM sidechain, that involves making at least two HTTP requests to external service, run by Flint Wallet, in the send form on each load. If this service is not responding, sending funds is blocked, even for users not intending to use the sidechain. The current application design is not resilient to this outage, disabling form fields until a response is received. #880 improved error handling, but to handle hanging requests, a client side timeout is required.
Solution
Abort the HTTP requests after 500ms, which should be sufficient time to receive a response without impacting UX.
Screencasts
Server timing out
Requests received