Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow messages with length > 2^16-2 #66

Closed
atiplea opened this issue Jan 18, 2019 · 0 comments · May be fixed by #85
Closed

Allow messages with length > 2^16-2 #66

atiplea opened this issue Jan 18, 2019 · 0 comments · May be fixed by #85
Labels
mtm Message transfer between the extension and Host

Comments

@atiplea
Copy link
Collaborator

atiplea commented Jan 18, 2019

It is not possible to "unpack" messages where the length is encoded in more than 2 bytes because of a hard-coded limitation. Found by @mreitsmaing

return ((firstByte * 256) + secondByte);

@atiplea atiplea added the mtm Message transfer between the extension and Host label Jan 18, 2019
@atiplea atiplea closed this as completed in 69a797d Aug 2, 2019
atiplea added a commit to atiplea/vscode-psl that referenced this issue Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mtm Message transfer between the extension and Host
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant