Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Calendar] Button backgrounds hard-codedly match the docs website background #2338

Open
aghArdeshir opened this issue Aug 20, 2024 · 1 comment · May be fixed by #2339
Open

[Calendar] Button backgrounds hard-codedly match the docs website background #2338

aghArdeshir opened this issue Aug 20, 2024 · 1 comment · May be fixed by #2339

Comments

@aghArdeshir
Copy link
Contributor

aghArdeshir commented Aug 20, 2024 •
edited
Loading

Expected behavior

The calendar by default to adapt nicely to different backgruonds.

Actual Behavior

Using the Calendar component on a non-white background is uglier than a white background.

https://studio.webcomponents.dev/edit/PE3zfOvHmOXlD5kRJRjM/README.md?p=README.md

image

image
image
image
image

Additional context

I believe changing background of the buttons to transparent instead of white solves the issue for white and non-white backgrounds. Not sure about any breaking implications! Are there any?

[cooking an MR]
@aghArdeshir aghArdeshir linked a pull request Aug 20, 2024 that will close this issue
Open
@aghArdeshir
Copy link
Contributor Author

This PR: #2339 intends to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Calendar] Calendar buttons look the same on non-white backgrounds aghArdeshir/lion
1 participant
@aghArdeshir