Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LionOverlays]: Doesn't close when clicking outside of iframe #2315

Open
gyulus3 opened this issue Jul 23, 2024 · 2 comments · May be fixed by #2316
Open

[LionOverlays]: Doesn't close when clicking outside of iframe #2315

gyulus3 opened this issue Jul 23, 2024 · 2 comments · May be fixed by #2316

Comments

@gyulus3
Copy link
Contributor

gyulus3 commented Jul 23, 2024

Expected behavior

Overlay closes when clicking outside of iframe.

Actual Behavior

Overlay stays open when clicking outside of iframe.
@gyulus3 gyulus3 linked a pull request Jul 23, 2024 that will close this issue
Open
@tlouisse
Copy link
Member

Hi @gyulus3 it's hard to detect for us what happens outside an iframe (we can only detect that an iframe loses focus, not whether a parent document is clicked).

In this case the parent document probably has to communicate to the iframe (child document) that a click was triggered.
In the child document, you can then close the relevant overlays based on that

@gyulus3
Copy link
Contributor Author

gyulus3 commented Aug 29, 2024

Hi @tlouisse! I've already created a PR for this issue where it basically listens for the blur event on the window. Please check this out: #2316

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(overlays): clicking outside iframe not closing the overlay gyulus3/lion
2 participants
@tlouisse @gyulus3