Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not compatible with winston-log-and-exit. #9

Open
jdthorpe opened this issue Oct 20, 2017 · 1 comment
Open

Not compatible with winston-log-and-exit. #9

jdthorpe opened this issue Oct 20, 2017 · 1 comment

Comments

@jdthorpe
Copy link

Hello,

I'm the author of the winston-log-and-exit, and have some users of this package have complained that this package doesn't work with winston-log-and-exit. As you may know, cleanly exiting a process and retaining the last few log entries is a perennial problem for winston users, which is confounded by poor documentation on how Winston identifies streaming loggers, and what API streaming loggers should implement.

In short, to work with winston-log-and-exit a custom Streaming Transport needs a ._stream attribute, has an .end() method, and which issues a "finish" event when all the messages that were logged before the .end() method was called.

Cheers,

-Jason

@imsky
Copy link
Owner

imsky commented Oct 20, 2017

hi @jdthorpe - i'm no longer using this package (no longer using rsyslog for logs), so if you'd like to add a patch, let me know and i'll add you as a collaborator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants