Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer to PostgreSQL Organization #587

Open
1 of 7 tasks
kdubb opened this issue Apr 3, 2023 · 22 comments
Open
1 of 7 tasks

Transfer to PostgreSQL Organization #587

kdubb opened this issue Apr 3, 2023 · 22 comments

Comments

@kdubb
Copy link
Member

kdubb commented Apr 3, 2023

In an effort to keep the driver alive and updated there is a tentative plan to move the project to the PostgreSQL organization. The hope is to bring more eyes, and make it easier to solicit maintainers as we go forward.

  • Add new maintainer(s).
  • Secure committer approval for transfer of copyright (Committer approval for transfer of copyright #588).
  • Update copyright headers in source code.
  • Rename project package to more appropriate for organization.
  • Fix outstanding security and vulnerability issues.
  • Transfer project to PostgreSQL organization.
  • Release 9.0
@kdubb
Copy link
Member Author

kdubb commented Apr 3, 2023

@davecramer Anything missing?

@davecramer
Copy link

@kdubb I'd like to see people step up before we moved it.

@kdubb
Copy link
Member Author

kdubb commented Apr 3, 2023

Added.

@davidwheeler123
Copy link
Collaborator

Any chance it could be renamed, once PostgreSQL takes it over? pgjdbc-ng is a mouthful!

@davecramer
Copy link

anything is "possible" I think the name was pgjdbc-ng where ng stood for next generation.
First I need to see people step up as maintainers.

@davidwheeler123
Copy link
Collaborator

First I need to see people step up as maintainers.

@davecramer How does this happen? Have we got a call out? How do we register our interest?

@davecramer
Copy link

davecramer commented Oct 16, 2023 via email

@davecramer
Copy link

Here is the place. So far nobody has shown any interest

@davidwheeler123
Copy link
Collaborator

Ok I'd be interested - but I'm not super familiar with the internals, and of course like many I'm subject to time constraints. But I imagine things like version bumps would be easy enough for me to get started on

I'm not sure others know that there's a call for contributors. I wonder if a post on a Postgres mailing list my get some support?

@kdubb
Copy link
Member Author

kdubb commented Oct 19, 2023

@davidwheeler123 I'm still around 😉

I have too many other projects that have stolen my focus. Additionally, we've moved to Quarkus and its reactive PG client.

That being said, I can still answer questions, lend guidance, and possibly work on bugs that require in-depth knowledge of the internals. Having maintenance help would be a big step.

@kdubb
Copy link
Member Author

kdubb commented Oct 19, 2023

There a lot of things about this driver that I still love (I'm biased I know)...

The two major things are...

1. It's Reactive

The protocol is implemented asynchronously and has a reactive interface that JDBC clobbers. With Java 21 this driver can take full advantage of virtual threads (aka Loom) and it should actually be as fast as a reactive driver. The driver's implementation of JDBC batch operations already uses this for a drastic speed improvement.

I did a lot of performance testing previously and the thread switching caused by Netty was the biggest performance issue previously; which can now be almost completely mitigated with Loom.

All of this should be fairly easy to update.

2. Pluggable type handling

All of the Postgres in/out functions are mirrored in Java and matched at runtime using a ServiceLoader. They're easy to edit and, because of the ServiceLoaders, can be provided by users of the driver (our old code did a bit of this).

CDI has a new lightweight model that can be used to make this even easier and give it the ability to work out of the box with modern frameworks built on CDI.

I want proper UDT support in the Vert.X driver we are using now and there is literally none.

@kdubb
Copy link
Member Author

kdubb commented Oct 25, 2023

@davidwheeler123 WRT #588 (comment)...

I'd say get started. Please explicitly add me as a reviewer on any PRs. I will keep engaged and merge them as they pass checks. Write access can be provided after discussing process.

@crowmagnumb
Copy link

What happened to this transfer idea. I'm super reliant on this driver right now because of it's support for UDT's and the old dependencies just put me in a tailspin today. Had to do some hoop jumping. Would love to see this maintained, or at least the UDT stuff incorporated in the main postgresql jdbc driver which I'ld rather switch back to. :)
Cheers.

@kdubb
Copy link
Member Author

kdubb commented May 30, 2024

@crowmagnumb The hold up is that @davecramer, rightfully, wants some maintainers to step up before we put in work to transfer the code. There's no point in transferring it to Postgres only to have it immediately fall into disarray.

That being said... there may be updates in the next months from myself. Don't take that as anything but speculation and hopefulness as a need for it has arisen in something new.

@davidwheeler123
Copy link
Collaborator

I'm keen to maintain, but the PR I put forward to refresh dependencies has stalled. Bit hard to become a maintainer on a project that doesn't accept PRs

@kdubb
Copy link
Member Author

kdubb commented May 31, 2024

@davidwheeler123 I apologize... I don't know what happened other than I missed this, or postponed getting to it and it fell off my radar.

@kdubb
Copy link
Member Author

kdubb commented May 31, 2024

@davidwheeler123 I fixed the PR requirements and merged it. I also invited you to the project. Please add me as a reviewer on PRs and allow me some time to weigh in. If I am non-responsive after 7 days, move forward.

@kdubb
Copy link
Member Author

kdubb commented May 31, 2024

WRT current outstanding PRs, please review them yourself and add me as a review when you are ready to merge; same rules as above for merging them.

@davidwheeler123
Copy link
Collaborator

@kdubb ok sounds good, thanks ❤️.

I don't know what happened other than I missed this, or postponed getting to it and it fell off my radar.

We all have lives I get it - on that, my life is pretty complex right now I can't see myself having much time to contribute over the next few months, but I'll do what I can to keep it ticking over in terms of resolving CVEs and the like

@crowmagnumb
Copy link

I can also throw my hat in the ring to help maintain it.

@davecramer
Copy link

So you guys might as well know about this sooner than later pgjdbc/pgjdbc#3306 not sure how that effects this project?

@crowmagnumb
Copy link

crowmagnumb commented Jul 7, 2024

Well that is certainly of great interest to me. Lack of UDT support was my reason for moving to this driver. I'll be watching that pull request closely. Thanks for the heads up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants