Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review DownloadAndCompareTasket #249

Open
rjcanto opened this issue Jun 10, 2021 · 0 comments
Open

Review DownloadAndCompareTasket #249

rjcanto opened this issue Jun 10, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@rjcanto
Copy link
Contributor

rjcanto commented Jun 10, 2021

The DownloadAndCompareTasket has multiple responsibilities in different layers of the architecture:

  • Application: it's a tasket/step from a batch job
  • Infrastructure: downloads a file and sends email notification

The proposal is to have the tasklet exclusively defined in the job implementation class, which then will make the call to the infrastructure services (download and notification)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rjcanto