-
-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: add reusable actions #2951
CI: add reusable actions #2951
Conversation
6559f71
to
2dace22
Compare
0827539
to
da6b7e2
Compare
FYI, there is a tool called |
Damn, didn't know that. Thanks. However I think I've mostly finished this PR. |
Ok, so if there are both a Alternatively I could make it so that |
c7ae5f0
to
849ba92
Compare
Maybe add a condition to skip this job in PR?
Every PR has failed this check since this commit. It generates extra noise in emails. |
Oops. Okay, I'll fix it. |
if: ${{ !startsWith(github.ref, "refs/pull/") && !endsWith(github.ref, "/merge") }} |
I came up with something like this name: Nix
on: [push, pull_request, workflow_dispatch]
jobs:
wlroots:
if: github.event_name == 'push'
uses: ./.github/workflows/nix-update-wlroots.yml
secrets: inherit
build:
if: always() && !cancelled() && !contains(needs.*.result, 'failure')
needs: wlroots
uses: ./.github/workflows/nix-build.yml
secrets: inherit since we still want the packages to be built even if wlroots updating was skipped. |
Describe your PR, what does it fix/add?
Allows reusing actions across the org, meaning less copied code and less chances of errors slipping in when a change is made.
nix flake check
(which does not guarantee the builds are run as the dependency graph dictates.)Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
See my comment below.
Is it ready for merging, or does it need work?
I also want to create a conditional job:
The above conditional was replaced by simply running the wlroots update first, and re-cloning HEAD from the branch on the subsequent package build job.