Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem updating user and space tags. #67

Closed
avillaindesire opened this issue Oct 3, 2021 · 5 comments
Closed

Problem updating user and space tags. #67

avillaindesire opened this issue Oct 3, 2021 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@avillaindesire
Copy link

According to the documentation, tags should be presented as a single comma delimited string. If I get a user or a space (e.g. /space/{id}), the tags come back as an array of strings. Trying to update the tags of a user or a space, either with a string or an array of strings, doesn't seem to work. Is updating tags broken or is the documentation incorrect?

@luke-
Copy link
Contributor

luke- commented Oct 4, 2021

Tags were recently reworked and therefore probably cause problems.
@yurabakhtin Can you take a look into this?

@luke- luke- added the bug Something isn't working label Oct 4, 2021
@yurabakhtin
Copy link
Contributor

@luke- Yes, the doc was wrong, I fixed it in PR #68, probably we should allow to use tags instead of from tagsField at least from REST module side, let me know if I should to find a solution.
Also Space tags were not updated from REST API side, I fixed in core PR humhub/humhub#5327.

@luke-
Copy link
Contributor

luke- commented Oct 5, 2021

@yurabakhtin Thank you for the quick fix.

I think the tagsField will work for now, but I have created an issue here for the future.

@luke- luke- closed this as completed Oct 5, 2021
@avillaindesire
Copy link
Author

@yurabakhtin I did a quick check and it looks like your changes fix the problem. The response back from the API call still says 'tags' instead of 'tagsField', but that doesn't get in the way of the functionality so I'm good with it.

@yurabakhtin
Copy link
Contributor

@avillaindesire Yes, the response still has the field tags, but in request we should use new tagsField. We just updated the doc pages to mark these fields as array instead of previous string format.
In next fix #69 we will make to use also tags from request side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants