Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix visibility of the method Controller::getAccessRules() #197

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Fix visibility of the method Controller::getAccessRules() #197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion controllers/MoveController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class MoveController extends BaseController
/**
* @inheritdoc
*/
public function getAccessRules()
protected function getAccessRules()
{
return [
['permission' => [ManageFiles::class]]
Expand Down
5 changes: 4 additions & 1 deletion controllers/UploadController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@
*/
class UploadController extends BrowseController
{
public function getAccessRules()
/**
* @inheritdoc
*/
protected function getAccessRules()
{
return [
['permission' => [WriteAccess::class]]
Expand Down
9 changes: 5 additions & 4 deletions controllers/ZipController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,9 @@
namespace humhub\modules\cfiles\controllers;

use humhub\modules\cfiles\actions\UploadZipAction;
use Yii;
use yii\web\HttpException;
use humhub\modules\cfiles\libs\ZIPCreator;
use humhub\modules\cfiles\widgets\FileList;
use yii\web\UploadedFile;
use Yii;

/**
* ZipController
Expand All @@ -23,7 +21,10 @@
class ZipController extends BrowseController
{

public function getAccessRules()
/**
* @inheritdoc
*/
protected function getAccessRules()
{
return [
['checkZipSupport']
Expand Down
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Changelog
0.16.3 - Unreleased
-----------------------
- Enh #194: Tests for `next` version
- Fix #197: Fix visibility of the method `Controller::getAccessRules()`

0.16.2 - September 4, 2023
---------------------------
Expand Down
Loading