diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index c68001d..637aca7 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -8,6 +8,7 @@ Changelog - Fix #184: Display only published content files in the folder "Files from the stream" - Fix #186: Rename conflicted not published folder/file on creating/uploading - Fix #189: Initialize module content class +- Fix #190: Fix folder visibility in private space - Fix #191: Avoid UnknownPropertyException in validation error response 0.16.1 - May 1, 2023 diff --git a/tests/codeception/_support/AcceptanceTester.php b/tests/codeception/_support/AcceptanceTester.php index b8fd389..6022eb7 100644 --- a/tests/codeception/_support/AcceptanceTester.php +++ b/tests/codeception/_support/AcceptanceTester.php @@ -130,7 +130,7 @@ public function createFolder($title = 'test', $description = 'test description', $this->fillField('Folder[description]', $description); if($isPublic) { - $this->click('[for="folder-visibility"]'); + $this->jsClick('input#folder-visibility'); } $this->click('Save', '#globalModal'); diff --git a/tests/codeception/acceptance/VisibilityCest.php b/tests/codeception/acceptance/VisibilityCest.php index 78a2768..a77481f 100644 --- a/tests/codeception/acceptance/VisibilityCest.php +++ b/tests/codeception/acceptance/VisibilityCest.php @@ -35,7 +35,7 @@ public function testVisibility(AcceptanceTester $I) $I->fillField('Folder[description]', 'visibility2'); $I->expect('The folder visibility to be private'); - $I->waitForElement('[for="folder-visibility"] input[type=checkbox]:disabled'); + $I->waitForElement('input#folder-visibility:disabled'); $I->click('Save', '#globalModal'); $I->waitForText('This folder is empty.'); @@ -55,7 +55,7 @@ public function testVisibility(AcceptanceTester $I) $I->amGoingTo('set the folder visibility to public'); $I->clickFolderContext(3, 'Edit'); $I->waitForText('Edit folder', null, '#globalModal'); - $I->click('[for="folder-visibility"]'); + $I->jsClick('input#folder-visibility'); $I->click('Save', '#globalModal'); $I->waitForText('visibility2', null, '#fileList'); diff --git a/views/edit/modal_edit_folder.php b/views/edit/modal_edit_folder.php index c95c627..a16a24a 100644 --- a/views/edit/modal_edit_folder.php +++ b/views/edit/modal_edit_folder.php @@ -1,6 +1,7 @@ field($folder, 'title'); ?> field($folder, 'description'); ?> - field($folder, 'visibility')->checkbox(['disabled' => !$folder->isRoot() && $folder->parentFolder->content->isPrivate()]) ?> - field($folder, 'hidden')->widget(ContentHiddenCheckbox::class, []); ?> + field($folder, 'visibility')->widget(ContentVisibilitySelect::class, ['readonly' => !$folder->isRoot() && $folder->parentFolder->content->isPrivate()]) ?> + field($folder, 'hidden')->widget(ContentHiddenCheckbox::class) ?> - \ No newline at end of file +