Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications / new Files #181

Open
Gilbertdelyon opened this issue May 26, 2023 · 4 comments
Open

Notifications / new Files #181

Gilbertdelyon opened this issue May 26, 2023 · 4 comments

Comments

@Gilbertdelyon
Copy link

Gilbertdelyon commented May 26, 2023

image
By default notifications for new files are Turned ON

Question 1:
Is there a way to turn them OFF by default ?

Question 2;
What does appen if you turn notifications OFF in the dropdown menu?? I guess that if you turn from ON to OFF before the next queue work the notification will not be sent, but what does appen if you turn after the queue work (to late)?

@Gilbertdelyon
Copy link
Author

Gilbertdelyon commented May 29, 2023

After some more testing, this is what I understand:
Context:
Private space
Private folder

STEP 1 Add a new file
It's private by default
Notification is added to queue and is sent to space members in any case (you cannot set with/without notification before uploading the file)
You cannot turn OFF notifications
STEP 2 Turn the file to public
Now you can turn ON/OFF notifications, but it's no use, because it's too late (that's what I have in mind)
STEP 3 Turn the file back to private
You can still turn ON/OFF notifications, that's funny because it was not possible in STEP 1 while the file was also private.

So, question 1 remains:
Is there a way to turn notification OFF by default?(even if the file is private)
This would be very usefull for ou site.

@felixhahnweilheim
Copy link

Notification is added to queue and is sent to space members in any case

Only if the user has turned on the new content notification for that space. (testing with HumHub 1.14.2 and cfiles 0.16.1)

You cannot turn OFF notifications

I cannot reproduce this. By default they are turned off and I can switch them on and off. Do you use any custom module that could interfere here? Or do you have any special settings (of the cfiles module)?

STEP 2 Turn the file to public

How do you set the file to public if your space is private?

@Gilbertdelyon
Copy link
Author

You are right.
Sorry, I made mistake between Private space and Private Content in a Public Space.
So, I performed new tests in all contexts:

Questions:
1/ What is the use of “turn OFF/ON notification” menu item ?
When this menu is visible it’s too late, notification is queued and users are already notified.
Nothing changes when you click this item. It remains ON
You have to change Private/Public status of the file to make this item usable

2/ Private Space / Private Content /… / Private Files cannot be turned to Public Files.(Menu item is hidden)
Is it a bug or is it the normal behavior?
This is strange because you can add Private Space / Private Content /… / Public Files.
So, Public files in Private Content are not forbidden at all

3/ In any case the users will receive a notification when a file is added. This is a big issue.
Suppose you add 10 or 20 new files, this will generate an amount of emails. Not good for the planet,
And the main point: Users will complain (This is what happened to me a week ago)
Instead I could have sent a unique post to the users with links to the files

Request for Enhancement:

  • Separate notification settings for new files vs new posts or comments
  • Provide a way to turn off notification for new files

@felixhahnweilheim
Copy link

felixhahnweilheim commented May 31, 2023

1/ This setting is about comments (and likes?) to the file.

I agree with your other points. There shouldn't be a notification for every file, a summary would be better or the possibility to switch notifications for new files off.
To be honest, I find the whole notification system is too confusing especially for new users.

Maybe a quick solution would be to limit e-mail notifications per hour/day and the last notification says "there is new content...".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants