Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To use a dedicates namespace for the logging. #152

Open
corradomio opened this issue Jun 3, 2024 · 1 comment
Open

To use a dedicates namespace for the logging. #152

corradomio opened this issue Jun 3, 2024 · 1 comment

Comments

@corradomio
Copy link

To use the Python 'logging' package to write logs is good.
BUT it is BETTER (and simple) to use a dedicated namespace, for example "castle.algorithm.<algo_name>" for the algorithms, and "castle.general" or similar names for the generic parts of the code, and NOT the 'root' namespace.
This because if the library is used in a more complex application, it permits to decide which logs to select.

@shaido987
Copy link
Collaborator

Thanks for the suggestion! The logging is a bit disorganized right now and could use a look-over to consistently use getLogger(__name__) or similar, and follow the same format everywhere.

Let us know if you are interested in making a PR for this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants