Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky Tomcat test #1

Open
rossabaker opened this issue May 27, 2021 · 7 comments
Open

Flaky Tomcat test #1

rossabaker opened this issue May 27, 2021 · 7 comments

Comments

@rossabaker
Copy link
Member

==> X org.http4s.tomcat.server.TomcatServerSuite.server should route requests on the service executor  5.567s munit.ComparisonFailException: /home/runner/work/http4s/http4s/tomcat-server/src/test/scala/org/http4s/tomcat/server/TomcatServerSuite.scala:97
96:      .map(_.startsWith("http4s-suite-"))
97:      .assert
98:  }
value is not true
=> Obtained
false
=> Diff (- obtained, + expected)
-false
+true

https://github.com/http4s/http4s/pull/4898/checks?check_run_id=2687198536

@rossabaker
Copy link
Member Author

This keeps happening. We should have the test at least tell us which thread it is.

@rossabaker
Copy link
Member Author

@isomarcte
Copy link
Member

@rossabaker do you think that is a default HTML error page? I should have re-written those better, to dump the whole output on failure.

@rossabaker
Copy link
Member Author

I just looked at the test name when I pinged you, and now GitHub can't find the log. 😩

@isomarcte
Copy link
Member

@rossabaker the string it was matching was something like <doctype

@rossabaker
Copy link
Member Author

Yep, sounds like. The default Tomcat error pages are all HTML.

@rossabaker
Copy link
Member Author

Here's another one

==> X org.http4s.tomcat.server.TomcatServerSuite.server should route requests on the service executor  6.272s munit.ComparisonFailException: /home/runner/work/http4s/http4s/tomcat-server/src/test/scala/org/http4s/tomcat/server/TomcatServerSuite.scala:101
100:      .map(_.take(prefix.size))
101:      .assertEquals(prefix)
102:  }
values are not the same
=> Obtained
<!doctype htm
=> Diff (- obtained, + expected)
-<!doctype htm
+http4s-suite-

It's probably the response timing out because we still ask too much of these free CI boxes.

@rossabaker rossabaker transferred this issue from http4s/http4s Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants