Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace M_PI by std::numbers::pi #441

Open
bernhardmgruber opened this issue Mar 8, 2023 · 1 comment
Open

Replace M_PI by std::numbers::pi #441

bernhardmgruber opened this issue Mar 8, 2023 · 1 comment
Labels

Comments

@bernhardmgruber
Copy link
Contributor

The exercises memcheck and polymorphism use the non-standard M_PI constant, which unfortunately for MSVC requires extra setup. If we would use std::numbers::pi instead from C++20, this special handling would not be necessary. However, it would move the exercises from C++17 to C++20. Would this be fine?

Copy link

stale bot commented Mar 7, 2024

This issue or pull request has been automatically marked as stale because it has not had recent activity. Please manually close it, if it is no longer relevant, or ask for help or support to help getting it unstuck. Let me bring this to the attention of @klieret @wdconinc @michmx for now.

@stale stale bot added the stale label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant