-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submit form via POST rather than GET #399
Comments
Hey! That does sound like a problem. Generally speaking, I don't think that POST requests are the right HTTP verb to use here, since we're not updating anything and since these requests could be cached safely for a short period of time. Is there any option to configure your firewall to allow long URLs just for your Hound instance? |
Yep. I can reconfigure our firewall. I was just submitting this issue in order to try to help others who run into this problem. If you don't want to change the HTTP verb, I guess we can just close this. Thanks for considering. |
Allowing the user to specify the repos to be searched by regex (rather than selecting every single one) might also mitigate this problem. |
@richardjq thats actually not a bad idea. A number of users seem to use hound with a pretty large number of repositories; I'd be interested in this. Do enough of you repositories share text in such a way that an expression would help? |
Yes. We tend to organize our repos (in gitlab) hierarchically. And since we have 3000+ repos, a regex or glob would help a great deal. |
Closing this in favor of #411. Thanks again, and feel free to reopen this issue if you think I'm missing some context. |
Please consider having hound submit search requests via post (or maybe make it optional?).
If you are indexing many, many repos and when you want to restrict your search to just many of them, the URI is quite long. If you run hound behind a web application firewall this is likely to be seen as an attack and result in a "414 Request-URI Too Long".
Thanks for considering.
The text was updated successfully, but these errors were encountered: