-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualizations that use zoom-level precisely are quite off #806
Comments
Ok still getting my web development feet wet again. This only happens on FF (of course). |
This happens also on google chrome by using the scale bar. So I would venture a guess it has something to do with bounding box calculations. |
Ok this also happens with the side-by-side viewer where one side will get thrown off. So I think there is something going on with the zoom level. |
@xinaesthete See here for more discussion. I have a suspicion this is related to visgl/deck.gl#8989 |
I think I might have another look into this in combination with updating React / MUI / zustand etc as I still think these things may be somewhat related. In MDV we don't have the janky scale-bar issue and can also load views with appropriate zoom, as well as linking viewState between charts. The latter gets confused if the images have different physical pixel size, but apart from that it seems to work reasonably well and most of the relevant code is based on refactored version of Avivator... There are some warnings from Zustand currently which it'd be good to get rid of and I'm not sure it's in-scope for the other PR, but it'd be nice to get a new release with all this somewhat cleaned up relatively soon... so I think I'll crack on with that now. |
I've just been looking at an image that was encoded in a not terribly useful way - it has a few hundred channels which should really be z-slices etc, and no physical size metadata for the pixels... that last point seems to be helping viv keep the side-by-side views in sync perfectly where others go badly wrong. |
Describe the bug
The scale bar is jumpy on the Avivator site (but somehow not on Vitessce). I imaging there is some sort of state management issue. In any case we should be rendering the scale bar in its own view anyway as suggested here
To Reproduce
avivator demo with a scale bar shows jumpiness
Expected behavior
The scale bar should be fixed like vitessce
Environment:
The text was updated successfully, but these errors were encountered: