Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options not reactive #17

Closed
jnordberg opened this issue Aug 30, 2020 · 2 comments
Closed

Options not reactive #17

jnordberg opened this issue Aug 30, 2020 · 2 comments
Labels
Status: Abandoned Issue will not be investigated / worked on any further Type: Bug Issue / bug

Comments

@jnordberg
Copy link

Component does not update if you change colors or chart options

@himynameisdave
Copy link
Owner

himynameisdave commented Sep 2, 2020

Interesting. I'll need to explore why this isn't working as expected. This would be a good place to start.

@himynameisdave himynameisdave added Status: Investigation Issue is being investigated more Type: Bug Issue / bug labels Sep 2, 2020
@himynameisdave
Copy link
Owner

himynameisdave commented Sep 3, 2020

@jnordberg while it's true that updating the colors prop (or other non-data props) does not update the chart, I believe that this is a limitation of the update method in the frappe-charts library itself. I'd recommend filing an issue over there, or seeing if there is a similar one which has been filed over there (looks like it may already have been worked on: frappe/charts#179).

Once that change lands, we will be able to make an update here to allow props such as colors to update the underlying chart. Closing this until that change hits.

@himynameisdave himynameisdave added Status: Abandoned Issue will not be investigated / worked on any further and removed Status: Investigation Issue is being investigated more labels Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Abandoned Issue will not be investigated / worked on any further Type: Bug Issue / bug
Projects
None yet
Development

No branches or pull requests

2 participants