Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No initialization of public key depending on constructor usage of file key provider #907

Closed
dkocher opened this issue Oct 23, 2023 · 0 comments · Fixed by #908 · May be fixed by #944
Closed

No initialization of public key depending on constructor usage of file key provider #907

dkocher opened this issue Oct 23, 2023 · 0 comments · Fixed by #908 · May be fixed by #944

Comments

@dkocher
Copy link
Contributor

dkocher commented Oct 23, 2023

We had an issue 1 that we failed to initialize the public key required for connections using certificates for authentication. This is caused by the implementation of OpenSSHKeyV1KeyFile and OpenSSHKeyFile requiring to use a particular constructor to make sure an attempt is made to initialize the public key 2 .

Footnotes

  1. Support OpenSSH with certificate user authentication iterate-ch/cyberduck#15183 ↩

  2. https://github.com/hierynomus/sshj/blob/ff4a4774bd1e3d45e9e796c2b17ef835e7e6d67f/src/main/java/net/schmizz/sshj/userauth/keyprovider/OpenSSHKeyFile.java#L88-L92 ↩
dkocher added a commit to iterate-ch/sshj that referenced this issue Oct 23, 2023
@dkocher
Add overloaded init methods that take the public key from a stream an…
a10bf3c 
…d properly initialize. Resolves hierynomus#907.
@dkocher dkocher mentioned this issue Oct 23, 2023
Merged
dkocher added a commit to iterate-ch/sshj that referenced this issue Oct 23, 2023
@dkocher
Add overloaded init methods that take the public key from a stream an…
5e39fe9 
…d properly initialize. Resolves hierynomus#907.
dkocher added a commit to iterate-ch/sshj that referenced this issue Oct 23, 2023
@dkocher
Add overloaded init methods that take the public key from a stream an…
64b1379 
…d properly initialize. Resolves hierynomus#907.
dkocher added a commit to iterate-ch/sshj that referenced this issue Oct 23, 2023
@dkocher
Add overloaded init methods that take the public key from a stream an…
30c402e 
…d properly initialize. Resolves hierynomus#907.
dkocher added a commit to iterate-ch/sshj that referenced this issue Oct 23, 2023
@dkocher
Add overloaded init methods that take the public key from a stream an…
58681bb 
…d properly initialize. Resolves hierynomus#907.
dkocher added a commit to iterate-ch/sshj that referenced this issue Apr 29, 2024
@dkocher
Add overloaded init methods that take the public key from a stream an…
68bc801 
…d properly initialize. Resolves hierynomus#907.
hierynomus pushed a commit that referenced this issue Apr 29, 2024
@dkocher
Add overloaded init methods that take the public key from a stream an… (
09e2ca5 
#908)

* Add overloaded init methods that take the public key from a stream and properly initialize. Resolves #907.

* Override public key.
@dkocher dkocher mentioned this issue May 14, 2024
Open
@dkocher dkocher mentioned this issue Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dkocher