Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on SciPy #313

Open
hello-binit opened this issue May 4, 2024 · 22 comments
Open

Remove dependency on SciPy #313

hello-binit opened this issue May 4, 2024 · 22 comments

Comments

@hello-binit
Copy link
Contributor

Both setup.py include SciPy as a dependency, when it's not used anywhere in the code. Therefore, it's safe to remove the dependency.

@hello-binit
Copy link
Contributor Author

Also remove Pandas since it's not used anywhere either.

@hello-binit
Copy link
Contributor Author

Also remove sympy

@hello-binit
Copy link
Contributor Author

also remove nose

@hello-binit
Copy link
Contributor Author

Remove "rplidar-roboticia" from Body's setup.py, but keep it in Tool's setup.py

@hello-binit
Copy link
Contributor Author

remove snakeviz

@hello-binit
Copy link
Contributor Author

remove pyusb from Body's setup.py, but keep it in Tool's setup.py

@hello-binit
Copy link
Contributor Author

Remove SpeechRecognition

@hello-binit
Copy link
Contributor Author

Remove pixel-ring

@hello-binit
Copy link
Contributor Author

Remove cma

@hello-binit
Copy link
Contributor Author

remove scikit-image

@hello-binit
Copy link
Contributor Author

remove open3d

@hello-binit
Copy link
Contributor Author

Remove urdf_parser_py from Body's setup.py (it is not in Tool's setup.py)

@hello-binit
Copy link
Contributor Author

Remove jsonschema, qtconsole, and jupyter. I believe we had these pinned for a bug related to Python2.

'jsonschema==2.6.0; python_version < "3.0"', 'qtconsole==4.7.7; python_version < "3.0"', 'jupyter', # required by juypter

@hello-binit
Copy link
Contributor Author

Remove llvmlite. I believe we had it pinned for a Numba bug related to Python2.

'llvmlite==0.31.0; python_version < "3.0"', 'numba', # numba required by stretch_funmap, depends on old llvmlite for py2

@hello-binit
Copy link
Contributor Author

Remove terminado.

'terminado==0.8.3; python_version < "3.0"', # depend on old terminado for py2

@hello-binit
Copy link
Contributor Author

Remove condition on Dynamixel SDK. Now that we only use Python3, we don't need ship versions of Stretch Body that support Py2.

https://github.com/hello-robot/stretch_body/blob/master/body/setup.py#L30C37-L30C108

@hello-binit
Copy link
Contributor Author

Remove condition on PyYaml. The latest is 6.0.1.

https://github.com/hello-robot/stretch_body/blob/master/body/setup.py#L31C29-L31C68

@hello-binit
Copy link
Contributor Author

Remove numpy-stl from Body's setup.py

@hello-binit
Copy link
Contributor Author

Remove playsound from Body's setup.py

@hello-binit
Copy link
Contributor Author

See if we can remove the pins on pyglet and trimesh in the Tool's setup.py. I think since we started using urchin instead of urdfpy, we no longer need those pins.

https://github.com/hello-robot/stretch_body/blob/master/tools/setup.py#L32C23-L32C85

@hello-binit
Copy link
Contributor Author

See if we can add a dependency on pyaudio here, and remove it from Stretch Install:

https://github.com/hello-robot/stretch_install/blob/5cba1f771d35978b0ee9246a3bd734ac3a29eb28/factory/22.04/stretch_install_system.sh#L37-L38

@hello-binit
Copy link
Contributor Author

See if we can add a dep on pyserial here, and remove it from Stretch Install:

https://github.com/hello-robot/stretch_install/blob/5cba1f771d35978b0ee9246a3bd734ac3a29eb28/factory/22.04/stretch_install_system.sh#L47-L48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant