Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sys check should ensure setuptool-scm not installed #295

Open
hello-binit opened this issue Feb 28, 2024 · 1 comment
Open

Sys check should ensure setuptool-scm not installed #295

hello-binit opened this issue Feb 28, 2024 · 1 comment
Assignees

Comments

@hello-binit
Copy link
Contributor

The stretch_system_check.py tool knows which packages should and shouldn't be installed. It checks this at the Apt/ROS level and prints out a warning to user if a package is installed that shouldn't be or vice versa.

Now, at the Python level, we have a library that shouldn't be installed: setuptools-scm. When this library is installed, the following errors are emitted from colcon build:

/home/hello-robot/.local/lib/python3.10/site-packages/setuptools_scm/_integration/setuptools.py:30: RuntimeWarning: 
ERROR: setuptools==59.6.0 is used in combination with setuptools_scm>=8.x

Your build configuration is incomplete and previously worked by accident!
setuptools_scm requires setuptools>=61

Suggested workaround if applicable:
 - migrating from the deprecated setup_requires mechanism to pep517/518
   and using a pyproject.toml to declare build dependencies
   which are reliably pre-installed before running the build tools

  warnings.warn(
[02/28/24 12:58:15] ERROR    listing git files failed - pretending there aren't any 

setuptools-scm has no function within our codebase and can be safety uninstalled. But it seems to be a dependency of one of the packages we do depend on, so it keeps returning. Therefore, sys check should emit a warning when it detects this library and provide a quick command to uninstall it.

@hello-binit
Copy link
Contributor Author

Seems it's getting installed when upgrading stretch body because of matplotlib.

Collecting setuptools-scm>=4 (from matplotlib<=3.5.0->hello-robot-stretch-body)
  Using cached setuptools_scm-8.0.4-py3-none-any.whl.metadata (6.4 kB)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant