Changed picker does not respect .git/info/exclude when in a worktree.

[loralb]

Summary

When defining ignore rules in .git/info/exclude, the changed file picker (space+g) does not respect them if running helix in a worktree.

Reproduction Steps

• Start with a clean working tree
• touch .ignore
• Run helix and open the changed picker: the .ignore file should appear
• Close helix, add .ignore in .git/info/exclude, run helix again and open the changed picker: the .ignore file should not appear
• Create a worktree (git worktree add _path_) and enter in that directory
• Run helix and open the changed picker: the .ignore file appears even if it should not

Helix log

Not relevant, anyway here it is:

2024-09-12T22:11:31.641 globset [DEBUG] glob converted to regex: Glob { glob: "*/Dockerfile.*", re: "(?-u)^.*/Dockerfile\\..*$", opts: GlobOptions { case_insensitive: false, literal_separator: false, backslash_escape: true, empty_alternates: false }, tokens: Tokens([ZeroOrMore, Literal('/'), Literal('D'), Literal('o'), Literal('c'), Literal('k'), Literal('e'), Literal('r'), Literal('f'), Literal('i'), Literal('l'), Literal('e'), Literal('.'), ZeroOrMore]) }
2024-09-12T22:11:31.641 globset [DEBUG] glob converted to regex: Glob { glob: "*/dockerfile.*", re: "(?-u)^.*/dockerfile\\..*$", opts: GlobOptions { case_insensitive: false, literal_separator: false, backslash_escape: true, empty_alternates: false }, tokens: Tokens([ZeroOrMore, Literal('/'), Literal('d'), Literal('o'), Literal('c'), Literal('k'), Literal('e'), Literal('r'), Literal('f'), Literal('i'), Literal('l'), Literal('e'), Literal('.'), ZeroOrMore]) }
2024-09-12T22:11:31.641 globset [DEBUG] glob converted to regex: Glob { glob: "*/Containerfile.*", re: "(?-u)^.*/Containerfile\\..*$", opts: GlobOptions { case_insensitive: false, literal_separator: false, backslash_escape: true, empty_alternates: false }, tokens: Tokens([ZeroOrMore, Literal('/'), Literal('C'), Literal('o'), Literal('n'), Literal('t'), Literal('a'), Literal('i'), Literal('n'), Literal('e'), Literal('r'), Literal('f'), Literal('i'), Literal('l'), Literal('e'), Literal('.'), ZeroOrMore]) }
2024-09-12T22:11:31.641 globset [DEBUG] glob converted to regex: Glob { glob: "*/containerfile.*", re: "(?-u)^.*/containerfile\\..*$", opts: GlobOptions { case_insensitive: false, literal_separator: false, backslash_escape: true, empty_alternates: false }, tokens: Tokens([ZeroOrMore, Literal('/'), Literal('c'), Literal('o'), Literal('n'), Literal('t'), Literal('a'), Literal('i'), Literal('n'), Literal('e'), Literal('r'), Literal('f'), Literal('i'), Literal('l'), Literal('e'), Literal('.'), ZeroOrMore]) }
2024-09-12T22:11:31.641 globset [DEBUG] glob converted to regex: Glob { glob: "*/.*ignore", re: "(?-u)^.*/\\..*ignore$", opts: GlobOptions { case_insensitive: false, literal_separator: false, backslash_escape: true, empty_alternates: false }, tokens: Tokens([ZeroOrMore, Literal('/'), Literal('.'), ZeroOrMore, Literal('i'), Literal('g'), Literal('n'), Literal('o'), Literal('r'), Literal('e')]) }
2024-09-12T22:11:31.641 globset [DEBUG] glob converted to regex: Glob { glob: "*/BUILD.*", re: "(?-u)^.*/BUILD\\..*$", opts: GlobOptions { case_insensitive: false, literal_separator: false, backslash_escape: true, empty_alternates: false }, tokens: Tokens([ZeroOrMore, Literal('/'), Literal('B'), Literal('U'), Literal('I'), Literal('L'), Literal('D'), Literal('.'), ZeroOrMore]) }
2024-09-12T22:11:31.641 globset [DEBUG] glob converted to regex: Glob { glob: "*/.env.*", re: "(?-u)^.*/\\.env\\..*$", opts: GlobOptions { case_insensitive: false, literal_separator: false, backslash_escape: true, empty_alternates: false }, tokens: Tokens([ZeroOrMore, Literal('/'), Literal('.'), Literal('e'), Literal('n'), Literal('v'), Literal('.'), ZeroOrMore]) }
2024-09-12T22:11:31.641 globset [DEBUG] glob converted to regex: Glob { glob: "*/.envrc.*", re: "(?-u)^.*/\\.envrc\\..*$", opts: GlobOptions { case_insensitive: false, literal_separator: false, backslash_escape: true, empty_alternates: false }, tokens: Tokens([ZeroOrMore, Literal('/'), Literal('.'), Literal('e'), Literal('n'), Literal('v'), Literal('r'), Literal('c'), Literal('.'), ZeroOrMore]) }
2024-09-12T22:11:31.641 globset [DEBUG] glob converted to regex: Glob { glob: "*/conf/*/*.{inc,conf}", re: "(?-u)^.*/conf/.*/.*\\.(?:conf|inc)$", opts: GlobOptions { case_insensitive: false, literal_separator: false, backslash_escape: true, empty_alternates: false }, tokens: Tokens([ZeroOrMore, Literal('/'), Literal('c'), Literal('o'), Literal('n'), Literal('f'), Literal('/'), ZeroOrMore, Literal('/'), ZeroOrMore, Literal('.'), Alternates([Tokens([Literal('c'), Literal('o'), Literal('n'), Literal('f')]), Tokens([Literal('i'), Literal('n'), Literal('c')])])]) }
2024-09-12T22:11:31.641 globset [DEBUG] glob converted to regex: Glob { glob: "*/Jenkinsfile.*", re: "(?-u)^.*/Jenkinsfile\\..*$", opts: GlobOptions { case_insensitive: false, literal_separator: false, backslash_escape: true, empty_alternates: false }, tokens: Tokens([ZeroOrMore, Literal('/'), Literal('J'), Literal('e'), Literal('n'), Literal('k'), Literal('i'), Literal('n'), Literal('s'), Literal('f'), Literal('i'), Literal('l'), Literal('e'), Literal('.'), ZeroOrMore]) }
2024-09-12T22:11:31.641 globset [DEBUG] built glob set; 1 literals, 0 basenames, 0 extensions, 0 prefixes, 129 suffixes, 9 required extensions, 10 regexes
2024-09-12T22:11:31.645 helix_view::clipboard [DEBUG] Using wl-copy+wl-paste to interact with the system and selection (primary) clipboard
2024-09-12T22:11:31.646 helix_tui::backend::crossterm [DEBUG] The keyboard enhancement protocol is supported in this terminal (checked in 482.859µs)
2024-09-12T22:11:31.646 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-09-12T22:11:31.897 helix_term::application [DEBUG] received editor event: IdleTimer
2024-09-12T22:11:32.600 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-09-12T22:11:32.850 helix_term::application [DEBUG] received editor event: IdleTimer
2024-09-12T22:11:33.037 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-09-12T22:11:33.072 helix_term::application [DEBUG] received editor event: Redraw
2024-09-12T22:11:33.072 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-09-12T22:11:33.107 helix_term::application [DEBUG] received editor event: Redraw
2024-09-12T22:11:33.107 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-09-12T22:11:33.287 helix_term::application [DEBUG] received editor event: IdleTimer
2024-09-12T22:11:33.288 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-09-12T22:11:33.291 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-09-12T22:11:36.782 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-09-12T22:11:37.033 helix_term::application [DEBUG] received editor event: IdleTimer
2024-09-12T22:11:37.495 helix_view::document [DEBUG] id 1 modified - last saved: 0, current: 0
2024-09-12T22:11:37.495 helix_term::job [DEBUG] waiting on jobs...

Platform

Linux

Terminal Emulator

alacritty 0.13.2

Installation Method

Archlinux/Fedora repository

Helix Version

helix 24.7 (079f544)