Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic changes to move from SealNote to SealNote Plus #20

Open
ajburley opened this issue Jul 14, 2019 · 6 comments
Open

Basic changes to move from SealNote to SealNote Plus #20

ajburley opened this issue Jul 14, 2019 · 6 comments
Assignees
@ajburley
Labels
enhancement New feature or request
Milestone
Release 0.9

Comments

@ajburley
Copy link
Collaborator

ajburley commented Jul 14, 2019 •
edited
Loading

Changes such as:

  • Removing the warning that this project is no longer maintained
  • Replacing SealNote with SealNote Plus in the README, and updating GitHub links in the README
  • Incrementing the version so we have a clean break (in the second component) in versioning
  • Changing the license to establish the copyright of the original author versus new author
  • Removing references/configuration for Travis CI and CodeCov, and references to the app entries on Play Store and F-Droid
  • Adding a History section to the README to explain this project's connection to the legacy one
  • Removing the original author's contact information from the README and replacing it with a note about using GitHub to track issues
  • Changing the Android package name
  • Changing the Java package name
  • Renaming the Sealnote module (and module directory) to SealNotePlusApp
  • Updating the About screen in the application
  • Update strings generally
  • Update login screen
  • Split app_name into short app name for launcher (SealNote+), and full app name to appear in other places such as PasswordActivity etc. (SealNote Plus)
  • Update app name appearing in keys, such as in styles.xml
  • More generally, search the codebase for any mention of twistedplane or Sealnote (with lowercase "n"), and replace them accordingly
  • Update the acknowledgements file to acknowledge SealNote (legacy)
  • Remove "write a review" and AppRater
@ajburley ajburley mentioned this issue Jul 15, 2019
Open
@ajburley
Copy link
Collaborator Author

ajburley commented Jul 15, 2019 •
edited
Loading

Relevant commits so far:

f86eacc - License updates
83f3a66 - README updates
c1b4dc6 and c3469c8 - version increments
0af4af4 - package name
8a56d8b - Travis CI

@ajburley ajburley added this to the Release 0.9 milestone Jul 15, 2019
@ajburley ajburley added the enhancement New feature or request label Jul 15, 2019
@ajburley
Copy link
Collaborator Author

Not really an enhancement, but this is rather an edge case and it's more an enhancement than a defect.

@ajburley ajburley mentioned this issue Jul 15, 2019
Open
@ajburley ajburley self-assigned this Jul 16, 2019
@ajburley
Copy link
Collaborator Author

The remaining changes can't really be performed until the project actually compiles. Therefore this is blocked by #37.

@ajburley ajburley added the blocked Cannot be progressed currently. label Jul 16, 2019
ajburley added a commit that referenced this issue Jul 17, 2019
@ajburley
Resolve #17 and resolve #37, see those issues for details. Also, in t…
cecc1ff 
…he context of #20, changed package name back to legacy package name temporarily, as this was causing a conflict due to the Java package differing from the Android package.
@ajburley
Copy link
Collaborator Author

ajburley commented Jul 17, 2019 •
edited
Loading

#37 is resolved now, so unblocking this (for now at least).

@ajburley ajburley removed the blocked Cannot be progressed currently. label Jul 17, 2019
@ajburley ajburley mentioned this issue Jul 17, 2019
Open
ajburley added a commit that referenced this issue Jul 17, 2019
@ajburley
#20 - rename package from com.twistedplane.sealnote to org.hawknetwor…
e20f5e3 
…k.sealnoteplus
ajburley added a commit that referenced this issue Jul 17, 2019
@ajburley
#20 - Rename Sealnote module to SealNotePlusApp
f5902b5
ajburley added a commit that referenced this issue Jul 17, 2019
@ajburley
#20 - Split app_name into short_app_name and full_app_name and set ac…
24c0367 
…cordingly
@ajburley
Copy link
Collaborator Author

Next steps:

  • change app_credits across default and different translations
  • change Sealnote.Theme to SealNotePlus.Theme across files
  • search for any remaining instances of twistedplane, ignoring case
  • search for any remaining instances of Sealnote, with case
  • search for all instances of sealnote, ignoring case

@ajburley
Copy link
Collaborator Author

Missed to update the acknowledgements file. Currently, the legacy app is recognized in the codebase, but not in the app itself!

@ajburley ajburley reopened this Jul 22, 2019
ajburley added a commit that referenced this issue Jul 22, 2019
@ajburley
#20 - minor README changes
5eb86a4
ajburley added a commit that referenced this issue Jul 22, 2019
@ajburley
#20 - specify correct SealNote name and exclude modifications
6b73ccf
@ajburley ajburley mentioned this issue Aug 8, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajburley ajburley

Labels
enhancement New feature or request
Projects
None yet
Milestone
Release 0.9
Development

No branches or pull requests
1 participant
@ajburley