Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memcpy/memset deprecation warning #221

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix memcpy/memset deprecation warning #221

wants to merge 2 commits into from

Conversation

topikettunen
Copy link

@topikettunen topikettunen commented Aug 2, 2023 •
edited by andreasabel
Loading

@topikettunen topikettunen mentioned this pull request Aug 2, 2023
Open
@topikettunen
Copy link
Author

topikettunen commented Aug 3, 2023 •
edited
Loading

@andreasabel, Seems that fillBytes was introduced in GHC 7.10.1 and base version 4.8.0.0. Are we still interested in supporting even older versions that failed the check? If so, I guess we could yank the fillBytes function from the newer versions and just wrap it in some preprocessor.

@andreasabel
Copy link
Member

@topikettunen, thanks for investigating!
There are basically 3 ways to proceed.

  1. Just leave the deprecation warnings in and worry about them once the functions get actually removed.
  2. Use base-compat to get fillBytes for older base: https://hackage.haskell.org/package/base-compat-0.13.0/docs/Foreign-Marshal-Utils-Compat.html#v:fillBytes
  3. Drop GHC < 7.10.

Maybe @bgamari should decide the course of action here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation warning for memset and memcpy with bytestring >= 0.11.5
2 participants
@topikettunen @andreasabel