This repository has been archived by the owner on Jan 5, 2024. It is now read-only.
enable-stack: true should be implied by other stack-related options
#142
Assignees
Labels
enhancement
New feature or request
re: inputs
Concerning handling the inputs to this action
re: stack
Concerning CIs using stack
Milestone
Comments
andreasabel
added
enhancement
andreasabel
added a commit
to haskell-actions/setup
that referenced
this issue
May 3, 2023
The options `enable-stack`, `stack-no-global`, `stack-setup-ghc` and `disable-matcher` are now proper booleans only accepting `true` or `false`. Previously, they were true when set to some non-empty string, even when set to "false" or "off" etc. `disable-matcher` is deprecated in favour of a new positive form `enable-matcher`. `enable-stack` is now implied by setting another stack-related option, i.e., one of `stack-version`, `stack-no-global` and `stack-setup-ghc`. Previously, it was a prerequisite to these options. Contradictory options now give an error, such as `stack-no-global` with `ghc-version` or `enable-stack: false` with `stack-version`. Fixes: haskell/actions#142
|
This is fixed in setup's new home by |
andreasabel
added a commit
to haskell-actions/setup
that referenced
this issue
Jan 27, 2024
The options `enable-stack`, `stack-no-global`, `stack-setup-ghc` and `disable-matcher` are now proper booleans only accepting `true` or `false`. Previously, they were true when set to some non-empty string, even when set to "false" or "off" etc. `disable-matcher` is deprecated in favour of a new positive form `enable-matcher`. `enable-stack` is now implied by setting another stack-related option, i.e., one of `stack-version`, `stack-no-global` and `stack-setup-ghc`. Previously, it was a prerequisite to these options. Contradictory options now give an error, such as `stack-no-global` with `ghc-version` or `enable-stack: false` with `stack-version`. Fixes: haskell/actions#142
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently, if you give
stack-versionbut forgetenable-stack: true, the action simply skips installation ofstack.A more user-friendly API would be to imply
enable-stack: trueif any of the other stack-related inputs is explicitly set by the user.The text was updated successfully, but these errors were encountered: