Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: for TransferTransaction, 3x improvements requested #727

Open
bguiz opened this issue Jul 11, 2024 · 1 comment
Open

docs: for TransferTransaction, 3x improvements requested #727

bguiz opened this issue Jul 11, 2024 · 1 comment
Assignees
@theekrystallee
Labels
bug Something isn't working

Comments

@bguiz
Copy link
Contributor

bguiz commented Jul 11, 2024

Description

(1) TransferTransaction accepts AccountId (documented) and also accepts and EVM address as a string.

Update the following pages to reflect this:

(2) The programmatically generated docs is missing the definition for the TransferTransaction.addHbarTransfer function

Update the following pages to reflect this:

(3) The programmatically generated docs is missing the definition for the TransferTransaction.TransferHbarInput type definition, which is required to be able to understand how to use the hbarTransfers parameter of the constructor of TransferTransaction.

Update the following pages to reflect this:

Steps to reproduce

N/A - see description

Additional context

Hedera network

testnet

Version

2.48.1

Operating system

macOS
@bguiz bguiz added the bug Something isn't working label Jul 11, 2024
@bguiz bguiz mentioned this issue Jul 12, 2024
Merged
@theekrystallee theekrystallee added this to the Sprint 23 milestone Jul 16, 2024
@theekrystallee theekrystallee self-assigned this Jul 16, 2024
gitbook-com bot pushed a commit that referenced this issue Jul 26, 2024
@theekrystallee @gitbook-bot
fixes #727 (GITBOOK-2709)
89a6a41
@theekrystallee
Copy link
Member

89a6a41 fixes number 1. 2 and 3 are for other teams

@theekrystallee theekrystallee removed this from the Sprint 23 milestone Jul 26, 2024
SimiHunjan added a commit that referenced this issue Jul 30, 2024
@SimiHunjan @theekrystallee
@ElijahLynn @bguiz @ed-marquez @Neurone
update with commits from main branch (#753)
84e1247 
* add mirror node release notes (GITBOOK-2689)

* add Validation Cloud json-rpc docs #724 (GITBOOK-2692)

* Deprecate Arkhia and add Validation Cloud #699 (GITBOOK-2693)

* Remove references to stateproof REST API #722 (GITBOOK-2696)

* add hello future hackathon info #723  (GITBOOK-2691)

* Remove references to stateproof REST API pt 2 #722 (GITBOOK-2697)

* #723 add hello future hackathon graphic (GITBOOK-2698)

* #695 update faucet guide (GITBOOK-2678)

* add how to connect metamask to hedera tutorial #725 (GITBOOK-2694)

* added v0.51 performance results graphic #732 (GITBOOK-2703)

* No subject (GITBOOK-2706)

* added v0.52 release dates #733 (GITBOOK-2705)

* No subject (GITBOOK-2707)

* Add minimum kernel mainline versions plus update distro list (#736)

Signed-off-by: Elijah Lynn <[email protected]>

* No subject (GITBOOK-2708)

* add clarifying note re: Hedera EVM support for keccak-256 #738 (GITBOOK-2711)

* added Hgraph to the list of mirror node providers #743 (GITBOOK-2720)

* No subject (GITBOOK-2721)

* pt 1 update instances of SL + links to new Hashgraph #747 (GITBOOK-2723)

* pt 2 update instances of SL + links to new Hashgraph #747 (GITBOOK-2724)

* pt 3 update instances of SL + links to new Hashgraph #747 (GITBOOK-2725)

* No subject (GITBOOK-2726)

* add testnet reset skipped dates #748 (GITBOOK-2727)

* docs: remove row "tools and resources" from portal vs faucet comparison table (#749)

- the row was redundant

* fixes #727 (GITBOOK-2709)

* added QuickNode to the list of RPC providers #750 (GITBOOK-2728)

* Minor updates to hackathon banner (#751)

Signed-off-by: Ed Marquez <[email protected]>

* fixes #751 (GITBOOK-2731)

* fixes #751 (GITBOOK-2732)

* Fixed smart contracts links; (#752)

Signed-off-by: Giuseppe Bertone <[email protected]>

---------

Signed-off-by: Elijah Lynn <[email protected]>
Signed-off-by: Ed Marquez <[email protected]>
Signed-off-by: Giuseppe Bertone <[email protected]>
Co-authored-by: krystal <[email protected]>
Co-authored-by: Elijah Lynn <[email protected]>
Co-authored-by: Brendan Graetz <[email protected]>
Co-authored-by: Ed Marquez <[email protected]>
Co-authored-by: Giuseppe Bertone <[email protected]>
SimiHunjan added a commit that referenced this issue Jul 30, 2024
@SimiHunjan @theekrystallee
@ElijahLynn @bguiz @ed-marquez @Neurone
Update with main (#755)
9eeca8a 
* add mirror node release notes (GITBOOK-2689)

* add Validation Cloud json-rpc docs #724 (GITBOOK-2692)

* Deprecate Arkhia and add Validation Cloud #699 (GITBOOK-2693)

* Remove references to stateproof REST API #722 (GITBOOK-2696)

* add hello future hackathon info #723  (GITBOOK-2691)

* Remove references to stateproof REST API pt 2 #722 (GITBOOK-2697)

* #723 add hello future hackathon graphic (GITBOOK-2698)

* #695 update faucet guide (GITBOOK-2678)

* add how to connect metamask to hedera tutorial #725 (GITBOOK-2694)

* added v0.51 performance results graphic #732 (GITBOOK-2703)

* No subject (GITBOOK-2706)

* added v0.52 release dates #733 (GITBOOK-2705)

* No subject (GITBOOK-2707)

* Add minimum kernel mainline versions plus update distro list (#736)

Signed-off-by: Elijah Lynn <[email protected]>

* No subject (GITBOOK-2708)

* add clarifying note re: Hedera EVM support for keccak-256 #738 (GITBOOK-2711)

* added Hgraph to the list of mirror node providers #743 (GITBOOK-2720)

* No subject (GITBOOK-2721)

* pt 1 update instances of SL + links to new Hashgraph #747 (GITBOOK-2723)

* pt 2 update instances of SL + links to new Hashgraph #747 (GITBOOK-2724)

* pt 3 update instances of SL + links to new Hashgraph #747 (GITBOOK-2725)

* No subject (GITBOOK-2726)

* add testnet reset skipped dates #748 (GITBOOK-2727)

* docs: remove row "tools and resources" from portal vs faucet comparison table (#749)

- the row was redundant

* fixes #727 (GITBOOK-2709)

* added QuickNode to the list of RPC providers #750 (GITBOOK-2728)

* Minor updates to hackathon banner (#751)

Signed-off-by: Ed Marquez <[email protected]>

* fixes #751 (GITBOOK-2731)

* fixes #751 (GITBOOK-2732)

* Fixed smart contracts links; (#752)

Signed-off-by: Giuseppe Bertone <[email protected]>

* GitBook: No commit message

---------

Signed-off-by: Elijah Lynn <[email protected]>
Signed-off-by: Ed Marquez <[email protected]>
Signed-off-by: Giuseppe Bertone <[email protected]>
Co-authored-by: krystal <[email protected]>
Co-authored-by: Elijah Lynn <[email protected]>
Co-authored-by: Brendan Graetz <[email protected]>
Co-authored-by: Ed Marquez <[email protected]>
Co-authored-by: Giuseppe Bertone <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theekrystallee theekrystallee

Labels
bug Something isn't working
Projects
Docs Sprint Board
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bguiz @theekrystallee