Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design fixes: icons #154

Closed
niryariv opened this issue Dec 7, 2020 · 4 comments
Closed

design fixes: icons #154

niryariv opened this issue Dec 7, 2020 · 4 comments
Assignees

Comments

@niryariv
Copy link

niryariv commented Dec 7, 2020

  1. icon should be white (we can use the icons from zeplin, if needed I can supply svg for the others)

  2. add 10px padding around icon so the text does not touch the icon box border

  3. box size should be 120x120 (currently 160x160)

  4. font should be 14px (currently 16px)

current:
Screen Shot 2020-12-07 at 14 23 40
goal:
Screen Shot 2020-12-07 at 14 21 19

@OriHoch
Copy link
Contributor

OriHoch commented Dec 7, 2020

  1. icons are the group image, displayed also on the group page and can be changed from the UI, e.g. https://kfar-saba.datacity.org.il/group/edit/environment
    2,3,4. will fix

@niryariv
Copy link
Author

niryariv commented Dec 7, 2020

  1. I know it's the group image and changeable on the UI, the key is that we want to default images to be the correct (white) one. If I need to supply them in svg or png white let me know, but I'm looking for a solution that doesn't require manually updating all the icons of the existing sites

  2. Make it 7px instead of 10px please

@OriHoch
Copy link
Contributor

OriHoch commented Dec 7, 2020

for existing instances it will be fastest to change manually, it will be best if you could upload the desired images for the group and check how it looks in both the homepage icons and in the individual group pages. Also need to handle the group icons for Kfar Saba which are different.

For new instances - I will modify the instance initialization task in this task - #157

@OriHoch
Copy link
Contributor

OriHoch commented Dec 7, 2020

design fixes done + deployed to all instances

@OriHoch OriHoch removed their assignment Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants