Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IssueCopyCommandTest logic about the target adapter #550

Open
shulard opened this issue Mar 23, 2016 · 2 comments
Open

Fix IssueCopyCommandTest logic about the target adapter #550

shulard opened this issue Mar 23, 2016 · 2 comments
Labels
RFC

Comments

@shulard
Copy link
Member

shulard commented Mar 23, 2016

Hello,

As discussed in the #546 PR, there is a problem with the destination adapter test logic.

Indeed, in the unit test, we start with the idea that the issue tracker to test is the one linked to the Application. With the recent updates it's not the case anymore. If the copy destination is not the same as source, we must create an adapter.

I think that we must need to allow retrieving the destination adapter when it's necessary to test directly on it.

To be discussed 😄.
shulard added a commit to shulard/gush that referenced this issue Mar 23, 2016
@shulard
Skip the IssueCopyCommand test on target adapter
8ce20c3 
With the issue copy adapter update, we must change the destination adapter testing logic.
The destination adapter is cloned / created during the issue copy, the `Application` issue tracker is not the right one to test anymore...

An issue as been opened gushphp#550
@sstok sstok added the RFC label Mar 23, 2016
@sstok
Copy link
Contributor

sstok commented Mar 23, 2016

Basically what we need is a mocked storage (not kept in the TestAdapter) which keeps track of the issues.

@shulard
Copy link
Member Author

shulard commented Mar 23, 2016

Nice idea, it'll help check all the things easily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
RFC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shulard @sstok